lkml.org 
[lkml]   [2010]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf_events: fix ordering bug in perf_output_sample()
From
Date
On Thu, 2010-03-18 at 14:42 +0200, Stephane Eranian wrote:
> In order to parse a sample correctly based on the information
> requested via sample_type, the kernel needs to save each component
> in a known order. There is no type value saved with each component.
> The current convention is that each component is saved according to
> the order in enum perf_event_sample_format. But perf_output_sample()
> was not completely following this convention, thereby making samples
> impossible to parse without internal kernel knowledge.
>
> This patch puts things in the right order.

NAK, not so actually, its in the order specified in the
PERF_RECORD_SAMPLE comment.



\
 
 \ /
  Last update: 2010-03-18 20:07    [W:0.063 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site