lkml.org 
[lkml]   [2010]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 4/7] drivers/net/wireless: Use STD_IW_HANDLER macro
    From
    Date
    On Wed, 2010-03-17 at 23:21 -0700, Joe Perches wrote:
    > Convert direct uses of [ (foo - SIOCIWFIRST) , fn)
    >
    > Signed-off-by: Joe Perches <joe@perches.com>
    ...
    > static const iw_handler wl3501_handler[] = {
    > - [SIOCGIWNAME - SIOCIWFIRST] = wl3501_get_name,
    ...
    > + STD_IW_HANDLER(SIOCGIWNAME, wl3501_get_name),

    You are introducing an unnecessary cast here. That's bad.

    --
    Regards,
    Pavel Roskin


    \
     
     \ /
      Last update: 2010-03-18 18:27    [W:4.671 / U:0.148 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site