lkml.org 
[lkml]   [2010]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
Lars Lindley wrote:
> I fixed all problems found by checkpatch.pl and removed CamelCase
> from argument names.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
> ---
> drivers/staging/winbond/mlmetxrx_f.h | 27 ++++++++++++++-------------
> 1 files changed, 14 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/winbond/mlmetxrx_f.h b/drivers/staging/winbond/mlmetxrx_f.h
> index 6c04e3e..02dfd46 100644
> --- a/drivers/staging/winbond/mlmetxrx_f.h
> +++ b/drivers/staging/winbond/mlmetxrx_f.h
> @@ -1,25 +1,26 @@
> -//================================================================
> -// MLMETxRx.H --
> -//
> -// Functions defined in MLMETxRx.c.
> -//
> -// Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved.
> -//================================================================
> +/* ================================================================
> + * MLMETxRx.H --
> + *
> + * Functions defined in MLMETxRx.c.
> + *
> + * Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved.
> + * ================================================================
> + */
> #ifndef _MLMETXRX_H
> #define _MLMETXRX_H
>
> #include "core.h"
>
> -void MLME_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
> +void MLME_GetNextPacket(struct wbsoft_priv *adapter,
> + struct wb35_descriptor *pdes);

Can we get rid of the "p" prefix (hungarian notation) while at it?

> u8 MLMESendFrame(struct wbsoft_priv *adapter,
> - u8 * pMMPDU, u16 len, u8 DataType);
> + u8 *pmmpdu, u16 len, u8 datatype);
>
> -void
> -MLME_SendComplete(struct wbsoft_priv *adapter, u8 PacketID,
> - unsigned char SendOK);
> +void MLME_SendComplete(struct wbsoft_priv *adapter, u8 packetid,
> + unsigned char sendok);
>
> #ifdef _IBSS_BEACON_SEQ_STICK_
> -s8 SendBCNullData(struct wbsoft_priv *adapter, u16 wIdx);
> +s8 SendBCNullData(struct wbsoft_priv *adapter, u16 widx);
> #endif
>
> #endif



\
 
 \ /
  Last update: 2010-03-18 18:15    [W:0.081 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site