lkml.org 
[lkml]   [2010]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/5] tmpfs: handle MPOL_LOCAL mount option properly
Date
> On Tue, 16 Mar 2010, KOSAKI Motohiro wrote:
>
> > commit 71fe804b6d5 (mempolicy: use struct mempolicy pointer in
> > shmem_sb_info) added mpol=local mount option. but its feature is
> > broken since it was born. because such code always return 1 (i.e.
> > mount failure).
> >
> > This patch fixes it.
> >
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Cc: Ravikiran Thirumalai <kiran@scalex86.org>
>
> Thank you both for finding and fixing these mpol embarrassments.
>
> But if this "mpol=local" feature was never documented (not even in the
> commit log), has been broken since birth 20 months ago, and nobody has
> noticed: wouldn't it be better to save a little bloat and just rip it out?

I have no objection if lee agreed, lee?
Of cource, if we agree it, we can make the new patch soon :)





\
 
 \ /
  Last update: 2010-03-18 00:55    [W:0.041 / U:4.636 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site