lkml.org 
[lkml]   [2010]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/4] signal_struct->count must die, initial changes
Date
> signal_struct->count in its current form must die.

Agreed. This series
Acked-by: Roland McGrath <roland@redhat.com>

> - otoh, we really need to make task->signal refcountable,
> just look at the extremely ugly task_rq_unlock_wait()
> called from __exit_signals().

Another of many good reasons for...

> - we should change the lifetime rules for task->signal,
> it should be pinned to task_struct. We have a lot of
> code which can be simplified after that.

Yes, and sighand too. I think there will be quite a torrent of cleanup we
can do after that.

Remember too that we should really change de_thread() altogether. It has
long-standing signal-losing races that we should fix. Changing the
lifetime rules may complicate that, or not. But they'll tie in together,
and when we do that we'll replace the notify_count again with something
else entirely.


Thanks,
Roland


\
 
 \ /
  Last update: 2010-03-17 22:53    [W:0.047 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site