lkml.org 
[lkml]   [2010]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] netpoll: allow spaces in its parameter
David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Wed, 17 Mar 2010 14:07:57 +0800
>
>> No, but silently accepting it as 0 is not correct, why don't
>> reject it if it is not allowed?
>
> You have to be careful even with that. For example, if two
> netconsoles are specified, seeing the space shouldn't
> kill the first netconsole specification we parsed.
>
> A warning perhaps, but outright rejection of all specifications is
> really bad behavior.

OK, I will put a warning there instead.

Thanks, David!



\
 
 \ /
  Last update: 2010-03-17 07:37    [from the cache]
©2003-2011 Jasper Spaans