Messages in this thread | | | Date | Wed, 17 Mar 2010 16:26:41 +0000 (GMT) | From | Hugh Dickins <> | Subject | Re: [PATCH 3/5] tmpfs: handle MPOL_LOCAL mount option properly |
| |
On Tue, 16 Mar 2010, KOSAKI Motohiro wrote:
> commit 71fe804b6d5 (mempolicy: use struct mempolicy pointer in > shmem_sb_info) added mpol=local mount option. but its feature is > broken since it was born. because such code always return 1 (i.e. > mount failure). > > This patch fixes it. > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Cc: Ravikiran Thirumalai <kiran@scalex86.org>
Thank you both for finding and fixing these mpol embarrassments.
But if this "mpol=local" feature was never documented (not even in the commit log), has been broken since birth 20 months ago, and nobody has noticed: wouldn't it be better to save a little bloat and just rip it out?
Hugh
| |