Messages in this thread | | | Subject | Re: checkpatch false positive | From | Joe Perches <> | Date | Wed, 17 Mar 2010 08:25:35 -0700 |
| |
On Wed, 2010-03-17 at 11:00 +0000, Richard Kennedy wrote: > I'm getting this error from checkpatch which is a false positive AFAICT. > I don't see any other way to code this macro so maybe this rule > shouldn't apply?. > > ERROR: space prohibited before open square bracket '[' > #24: FILE: drivers/staging/wlan-ng/p80211wext.c:1685: > +#define IW_IOCTL(x) [(x)-SIOCSIWCOMMIT]
While true that this is a false positive, hiding array indexing brackets in a macro doesn't seem a good idea.
Maybe it'd be better to move the brackets to the use?
| |