[lkml]   [2010]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: checkpatch false positive
    On Wed, 2010-03-17 at 11:00 +0000, Richard Kennedy wrote:
    > I'm getting this error from checkpatch which is a false positive AFAICT.
    > I don't see any other way to code this macro so maybe this rule
    > shouldn't apply?.
    > ERROR: space prohibited before open square bracket '['
    > #24: FILE: drivers/staging/wlan-ng/p80211wext.c:1685:
    > +#define IW_IOCTL(x) [(x)-SIOCSIWCOMMIT]

    While true that this is a false positive, hiding array indexing
    brackets in a macro doesn't seem a good idea.

    Maybe it'd be better to move the brackets to the use?

     \ /
      Last update: 2010-03-17 16:27    [W:0.019 / U:5.400 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site