lkml.org 
[lkml]   [2010]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[Patch] netpoll: allow spaces in its parameter

It would be nice if we allow spaces in netconsole parameters,
otherwise we get weird results if there are spaces in it.

After this patch, we will allow things like:
"netconsole= @192.168.0.1/eth0 , 66666@192.168.0.2/".
Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: David Miller <davem@davemloft.net>

---
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 7aa6972..bf3b2f0 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -629,6 +629,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
char *cur=opt, *delim;

if (*cur != '@') {
+ cur = skip_spaces(cur);
if ((delim = strchr(cur, '@')) == NULL)
goto parse_failed;
*delim = 0;
@@ -651,12 +652,14 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
if ((delim = strchr(cur, ',')) == NULL)
goto parse_failed;
*delim = 0;
+ strim(cur);
strlcpy(np->dev_name, cur, sizeof(np->dev_name));
cur = delim;
}
cur++;

if (*cur != '@') {
+ cur = skip_spaces(cur);
/* dst port */
if ((delim = strchr(cur, '@')) == NULL)
goto parse_failed;

\
 
 \ /
  Last update: 2010-03-17 06:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site