lkml.org 
[lkml]   [2010]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] infiniband: ulp/iser, fix error retval in iser_create_ib_conn_res
On Tue, Mar 16, 2010 at 04:52:43PM -0700, Roland Dreier wrote:
> > ib_conn->login_buf = kmalloc(ISER_RX_LOGIN_SIZE, GFP_KERNEL);
> > if (!ib_conn->login_buf) {
> > - goto alloc_err;
> > ret = -ENOMEM;
> > + goto alloc_err;
> > }
>
> This looks like a valid fix but it's the same part of the code that Dan
> found more extensive bugs in. Or, can I assume you'll sort this out and
> make sure a final patch is sorted out?
>

My patch is the one to take. It addresses this problem here and fixes
some double frees.

http://marc.info/?l=linux-rdma&m=126872745710910&w=2

Sorry about that Jiri. Btw. Julia Lawall, Daren Jenkins and I normally CC
kernel-janitors for static checker patches.

regards,
dan carpenter

> Thanks,
> Roland
> --
> Roland Dreier <rolandd@cisco.com>
> For corporate legal information go to:
> http://www.cisco.com/web/about/doing_business/legal/cri/index.html


\
 
 \ /
  Last update: 2010-03-17 16:13    [W:0.094 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site