Messages in this thread | | | Date | Wed, 17 Mar 2010 10:59:57 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit kernels V2. |
| |
* T?r?k Edwin <edwintorok@gmail.com> wrote:
> >> + } > >> + return; > > > > This whole new block should probably be in a helper inline? > > To reduce indenting, or why?
Mainly to increase cleanliness. We want code that isolates separate blocks of logic into separate sections. So a simple construct of:
if (perf_callchain_user32(regs, entry)) return;
will tell the reader of the code that 'ok, this is 32-bit compat stuff'. It doesnt, at this level, intrude into the main logic of that function. Then if we look at perf_callchain_user32() we see all the 32-bit compat stack frame walking details.
Thanks,
Ingo
| |