lkml.org 
[lkml]   [2010]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit kernels V2.

* T?r?k Edwin <edwintorok@gmail.com> wrote:

> >> + }
> >> + return;
> >
> > This whole new block should probably be in a helper inline?
>
> To reduce indenting, or why?

Mainly to increase cleanliness. We want code that isolates separate blocks of
logic into separate sections. So a simple construct of:

if (perf_callchain_user32(regs, entry))
return;

will tell the reader of the code that 'ok, this is 32-bit compat stuff'. It
doesnt, at this level, intrude into the main logic of that function. Then if
we look at perf_callchain_user32() we see all the 32-bit compat stack frame
walking details.

Thanks,

Ingo


\
 
 \ /
  Last update: 2010-03-17 11:03    [W:0.070 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site