lkml.org 
[lkml]   [2010]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC] remove implicit slab.h inclusion from percpu.h
    From
    On Tue, Mar 16, 2010 at 10:23 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
    > On Tue, Mar 16, 2010 at 9:56 AM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
    >> Alexey Dobriyan kirjoitti:
    >>>
    >>> On Tue, Mar 16, 2010 at 8:58 AM, Pekka Enberg <penberg@cs.helsinki.fi>
    >>> wrote:
    >>>>
    >>>> We should avoid creating tree-wide breakage for this kind of cleanups.
    >>>
    >>> This is done by compile testing, not by being smartass.
    >>
    >> I don't think compile testing is going to scale here because slab is used is
    >> so many places of the kernel.
    >
    > Sigh.
    >
    > If you want to skip compile testing, just say so in changelog.

    Hey, "sigh" right back at you, Alexey!

    I am not saying I want to skip "compile testing", I'm just stating the
    obvious fact: for a header such as slab.h that's implicitly needed in
    pretty much everywhere, it's very difficult to find all the relevant
    broken configurations. I don't see the benefit of breaking the world
    for this cleanup as Ingo's suggestion will eventually get us to the
    exact same situation _without_ causing tree-wide breakage.

    Pekka


    \
     
     \ /
      Last update: 2010-03-16 10:09    [W:2.160 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site