Messages in this thread | | | Date | Tue, 16 Mar 2010 11:06:27 +0200 | Subject | Re: [RFC] remove implicit slab.h inclusion from percpu.h | From | Pekka Enberg <> |
| |
On Tue, Mar 16, 2010 at 10:23 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote: > On Tue, Mar 16, 2010 at 9:56 AM, Pekka Enberg <penberg@cs.helsinki.fi> wrote: >> Alexey Dobriyan kirjoitti: >>> >>> On Tue, Mar 16, 2010 at 8:58 AM, Pekka Enberg <penberg@cs.helsinki.fi> >>> wrote: >>>> >>>> We should avoid creating tree-wide breakage for this kind of cleanups. >>> >>> This is done by compile testing, not by being smartass. >> >> I don't think compile testing is going to scale here because slab is used is >> so many places of the kernel. > > Sigh. > > If you want to skip compile testing, just say so in changelog.
Hey, "sigh" right back at you, Alexey!
I am not saying I want to skip "compile testing", I'm just stating the obvious fact: for a header such as slab.h that's implicitly needed in pretty much everywhere, it's very difficult to find all the relevant broken configurations. I don't see the benefit of breaking the world for this cleanup as Ingo's suggestion will eventually get us to the exact same situation _without_ causing tree-wide breakage.
Pekka
| |