[lkml]   [2010]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC] remove implicit slab.h inclusion from percpu.h
    On Tue, Mar 16, 2010 at 9:57 AM, Ingo Molnar <> wrote:
    > Well, that's the main question: do we want all-in-one big headers like
    > kernel.h (and sched.h / mm.h) or not?

    It's question only for you.

    There are observations, like sched.h includes some VM routines which
    better live in mm.h and some some cred/UID routines which better live
    in cred.h and sched.h unnecessarily includes capability.h which wasn't
    removed after "struct cred" inclusion.

    > If we want to avoid combo .h files then we inevitably want to go for
    > finegrained, per subsystem data type and API definitions - i.e. explicit
    > slab.h inclusion in the .c file.

    The problem is that slab.h is included unnecessarily in some other headers
    conditionally and unconditionally.

    It's amazing to see how much sidework people are willing to create
    to _not_ do simple and obvious thing -- just remove slab.h.

     \ /
      Last update: 2010-03-16 09:35    [W:0.021 / U:81.812 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site