lkml.org 
[lkml]   [2010]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] remove implicit slab.h inclusion from percpu.h

* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> Alexey Dobriyan kirjoitti:
> >On Tue, Mar 16, 2010 at 8:58 AM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> >> We should avoid creating tree-wide breakage for this kind of cleanups.
> >
> > This is done by compile testing, not by being smartass.
>
> I don't think compile testing is going to scale here because slab is used is
> so many places of the kernel.

Yes. In large-scale conversions i typically used (rather extensive)
build-testing as a tool to check a script's correctness - distinctly _not_ to
create the actual patch itself.

I.e. it's an adaptive feedback loop in essence: the script gets perfected by
repeated build tests, and the end result is that we have a scripted conversion
that covers more code than build testing is able to reach (it covers not just
x86, covers rare config combos, etc.), _plus_ we also have the final proof of
the pudding via the actual build tests.

In the end it all converges nicely and the build breakage exported is minimal.

That is the mechanism i suggested. Alexey calls it 'smartass', i call it a
defensive approach to large-scale changes, that we should practice more, not
less.

[ Or, sometimes, for visibly trivial matters i just take the gamble, go into
cowboy mode and say 'to the heck, let others find those bugs' and do a
change based on a sed -i oneliner and build a few configs, fix up the
breakages it finds and hope for the best. I dont complain when i get slapped
for that though ;-) ]

Ingo


\
 
 \ /
  Last update: 2010-03-16 09:27    [W:0.064 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site