Messages in this thread | | | Date | Wed, 17 Mar 2010 07:57:40 +0900 | From | Tejun Heo <> | Subject | Re: [RFC] remove implicit slab.h inclusion from percpu.h |
| |
Hello,
On 03/17/2010 01:16 AM, Christoph Lameter wrote: > On Thu, 11 Mar 2010, Tejun Heo wrote: > >> Lee Schermerhorn was trying to use percpu from slab.h and ran into a >> dependency loop. percpu.h was using slab.h for UP inline > > The problem is that percpu.h includes slab.h for the UP case.
Yes, that's the reason why slab.h is included in percpu.h unconditionally.
> slab.h does not use percpu.h. Lee was trying to have topology.h use > percpu.h which fails because percpu.h uses gfp.h which in turn uses > topology.h again.
But apparently a lot of files depend on getting slab.h through percpu.h and removing slab.h causes a lot of build breakages UP or SMP.
> Did something change there or does the description need an update?
I don't find anything too wrong about the description?
Thanks.
-- tejun
| |