Messages in this thread | | | Subject | Re: CONFIG_MTD_DEBUG vs generic DEBUG support in kernel.h | From | Artem Bityutskiy <> | Date | Tue, 16 Mar 2010 15:05:59 +0200 |
| |
On Tue, 2010-03-16 at 13:55 +0100, Ferenc Wagner wrote: > Hi, > > include/linux/mtd/mtd.h contains the following snippet: > > #ifdef CONFIG_MTD_DEBUG > #define DEBUG(n, args...) \ > do { \ > if (n <= CONFIG_MTD_DEBUG_VERBOSE) \ > printk(KERN_INFO args); \ > } while(0) > > which conflicts with the generic debugging support in > include/linux/kernel.h: > > #ifdef DEBUG > #define pr_devel(fmt, ...) \ > printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) > > (that is, gcc emits redefinition warnings on modules which > #define DEBUG on their own and also include mtd.h) > Unfortunately, the DEBUG macro is used rather heavily under > drivers/mtd. Should we resolve this somehow or is it better > to just live with it? > > (Please keep me on Cc, I'm not subscribed.)
IMO, this MTD debug stuff is not very useful and could be just killed.
-- Best Regards, Artem Bityutskiy (Артём Битюцкий)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |