Messages in this thread | | | Date | Tue, 16 Mar 2010 12:28:22 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH -tip] rcu: local_irq_disable() also delimits RCU_SCHED read-site critical sections |
| |
* Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> It is documented that local_irq_disable() also delimits > RCU_SCHED read-site critical sections. > See the document of synchronize_sched() or > Documentation/RCU/whatisRCU.txt. > > So we have to test irqs_disabled() in rcu_read_lock_sched_held(). > Otherwise rcu-lockdep brings incorrect complaint.
It would be useful to include the warning in question in the changelog - so that others who might be affected by it can see the fix and can track its progress. (and dont start a parallel effort debugging/reporting/fixing it)
Thanks,
Ingo
| |