lkml.org 
[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/4] Fix typo: udpate => update
    Thomas Weber wrote:
    > Signed-off-by: Thomas Weber <swirl@gmx.li>
    > ---
    > Documentation/kbuild/kconfig.txt | 2 +-
    > drivers/firewire/ohci.c | 2 +-

    The firewire part is of course
    Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

    > drivers/infiniband/hw/ipath/ipath_iba6110.c | 2 +-
    > drivers/infiniband/hw/ipath/ipath_iba6120.c | 4 ++--
    > drivers/infiniband/hw/ipath/ipath_iba7220.c | 2 +-
    > drivers/isdn/hisax/hfc4s8s_l1.c | 2 +-
    > drivers/staging/rtl8187se/r8180_core.c | 4 ++--

    See comment on this part below.

    > drivers/staging/rtl8187se/r8180_dm.c | 2 +-
    > drivers/staging/rtl8187se/r8185b_init.c | 2 +-

    Ditto.

    > fs/jfs/jfs_dmap.c | 2 +-
    > 10 files changed, 12 insertions(+), 12 deletions(-)
    >
    [...]
    > --- a/drivers/staging/rtl8187se/r8180_core.c
    > +++ b/drivers/staging/rtl8187se/r8180_core.c
    > @@ -2364,7 +2364,7 @@ void rtl8180_wmm_param_update(struct work_struct * work)
    > u8 u1bAIFS;
    > u32 u4bAcParam;
    > pAcParam = (PAC_PARAM)(&AcParam);
    > - // Retrive paramters to udpate.
    > + // Retrive paramters to update.
    > u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN *(((mode&IEEE_G) == IEEE_G)?9:20) + aSifsTime;
    > u4bAcParam = ((((u32)(pAcParam->f.TXOPLimit))<<AC_PARAM_TXOP_LIMIT_OFFSET)|
    > (((u32)(pAcParam->f.Ecw.f.ECWmax))<<AC_PARAM_ECW_MAX_OFFSET)|

    "Retrieve" and "parameters".
    (You are fixing "parameters" in patch 3/4 --- why not right here?)

    > @@ -2400,7 +2400,7 @@ void rtl8180_wmm_param_update(struct work_struct * work)
    > u8 u1bAIFS;
    > u32 u4bAcParam;
    >
    > - // Retrive paramters to udpate.
    > + // Retrive paramters to update.
    > eACI = pAcParam->f.AciAifsn.f.ACI;
    > //Mode G/A: slotTimeTimer = 9; Mode B: 20
    > u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN * (((mode&IEEE_G) == IEEE_G)?9:20) + aSifsTime;

    Ditto.

    > --- a/drivers/staging/rtl8187se/r8185b_init.c
    > +++ b/drivers/staging/rtl8187se/r8185b_init.c
    > @@ -1128,7 +1128,7 @@ ActUpdateChannelAccessSetting(
    > u8 u1bAIFS;
    > u32 u4bAcParam;
    >
    > - // Retrive paramters to udpate.
    > + // Retrive paramters to update.
    > eACI = pAcParam->f.AciAifsn.f.ACI;
    > u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN * ChnlAccessSetting->SlotTimeTimer + aSifsTime;
    > u4bAcParam = ( (((u32)(pAcParam->f.TXOPLimit)) << AC_PARAM_TXOP_LIMIT_OFFSET) |

    Ditto.

    By the way, some of the staging drivers are undergoing heavy
    reformatting, hence it may be better to submit spelling fixes in those
    separately from non-staging code. (I don't know if this is the case
    with rtl8187se in particular.)
    --
    Stefan Richter
    -=====-==-=- --== -====
    http://arcgraph.de/sr/


    \
     
     \ /
      Last update: 2010-03-15 22:43    [W:0.044 / U:95.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site