lkml.org 
[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] kmod: add init function to usermodehelper
On Mon, Mar 15, 2010 at 06:34:54PM +0100, Oleg Nesterov wrote:
> On 03/15, Neil Horman wrote:
> >
> > --- a/kernel/kmod.c
> > +++ b/kernel/kmod.c
> > @@ -116,27 +116,16 @@ int __request_module(bool wait, const char *fmt, ...)
> >
> > trace_module_request(module_name, wait, _RET_IP_);
> >
> > - ret = call_usermodehelper(modprobe_path, argv, envp,
> > - wait ? UMH_WAIT_PROC : UMH_WAIT_EXEC);
> > + ret = call_usermodehelper_fns(modprobe_path, argv, envp,
> > + wait ? UMH_WAIT_PROC : UMH_WAIT_EXEC,
> > + NULL, NULL, NULL);
>
> This change looks unnecessary, but doesn't hurt.
>
Yeah, I concur, it was part of the origional patch, when that
call_usermodehelper had already been replaced with call_usermodehelper_cleanup.
I made my change anyway, figuring part of the purpose of this longer term would
be to convert the call_usermodehelper functions to the init/cleanup enabled
variants, which andi's patchset will eventually do here
Neil

> Reviewed-by: Oleg Nesterov <oleg@redhat.com>
>
>


\
 
 \ /
  Last update: 2010-03-15 18:59    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site