lkml.org 
[lkml]   [2010]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] tomoyo: fix potential use after free
From
Date
Dan Carpenter wrote:

> The original code returns a freed pointer. This function is expected to
> return NULL on errors.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Oh, thank you.
James, please send this patch to 2.6.34-rc1 .

Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

> diff --git a/security/tomoyo/common.c b/security/tomoyo/common.c
> index ff51f10..ef89947 100644
> --- a/security/tomoyo/common.c
> +++ b/security/tomoyo/common.c
> @@ -886,6 +886,7 @@ static struct tomoyo_profile *tomoyo_find_or_assign_new_profile(const unsigned
> ptr = kmalloc(sizeof(*ptr), GFP_KERNEL);
> if (!tomoyo_memory_ok(ptr)) {
> kfree(ptr);
> + ptr = NULL;
> goto ok;
> }
> for (i = 0; i < TOMOYO_MAX_CONTROL_INDEX; i++)


\
 
 \ /
  Last update: 2010-03-13 13:07    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site