Messages in this thread | | | Date | Sat, 13 Mar 2010 11:37:16 +0100 | From | Stefan Richter <> | Subject | Re: [PATCH] staging: winbond: Formatting, whitespace etc in mds.c I fixed most of the problems found by checkpatch.pl. Some long lines are left and some KERN_.. Signed-off-by: Lars Lindley <> |
| |
Lars Lindley wrote: > + } else { /*DSSS*/ > + /*CTS duration > + *2 SIFS + DATA transmit time + 1 ACK > + * Rate : ?? Mega bps > + *ACK frame length = 14 bytes*/ > + if (pT01->T01_plcp_header_length) /*long preamble*/ > + Duration = LONG_PREAMBLE_PLUS_PLCPHEADER_TIME*2; > else > - Duration = SHORT_PREAMBLE_PLUS_PLCPHEADER_TIME*2; > + Duration = SHORT_PREAMBLE_PLUS_PLCPHEADER_TIME*2;
Multiline comments are formatted as /* * 1st line * last line */ in new code.
The whitespace in the if--else clause went worse. Indent by tabs, not spaces. Furthermore, there should be spaces around * operators.
(BTW, winbond/README alias winbond/TODO doesn't mention it, but another (trivial) step is going to be to change variable names and function names from CamelCase to lower_case spelling.) -- Stefan Richter -=====-==-=- --== -==-= http://arcgraph.de/sr/
| |