lkml.org 
[lkml]   [2010]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] arch/mips/txx9/generic: init dynamic bin_attribute structures
    On Sat, Mar 13, 2010 at 03:28:55AM +0100, Wolfram Sang wrote:
    > On Fri, Mar 12, 2010 at 10:34:51AM -0800, Dmitry Torokhov wrote:
    > > On Fri, Mar 12, 2010 at 08:03:49AM +0100, Wolfram Sang wrote:
    > > > Commit 6992f5334995af474c2b58d010d08bc597f0f2fe introduced this requirement.
    > > > Found with coccinelle, but fixed manually. Compile tested on X86 where
    > > > possible.
    > > >
    > >
    > > Regarding all 3 - it looks like these dynamically alocated attributes
    > > could be converted to statically allocated ones. I'd recommend doing
    > > that instead (in fact, I posted patch for the firmware_class couple days
    > > ago).
    >
    > I agree for the firmware-patch. Regarding the MIPS one, 'size' might differ and
    > 'private' will differ per instance. Regarding the RTC driver, 'size' might also
    > differ. I don't know if somebody really wants two RTCs or the SRAM for MIPS can
    > be instantiated more than once. Unless somebody with actual hardware jumps in,
    > I'd say better safe than sorry.
    >

    Ah, right, size... I forgot about it. You are right, making the other 2
    static is not an option.

    --
    Dmitry


    \
     
     \ /
      Last update: 2010-03-13 09:37    [W:0.022 / U:62.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site