Messages in this thread |  | | | Date | Sat, 13 Mar 2010 16:55:15 -0600 | | From | Larry Finger <> | | Subject | Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70 |
| |
On 03/13/2010 04:32 PM, Linus Torvalds wrote: > > > On Sat, 13 Mar 2010, Larry Finger wrote: >> >> Commit a2db6842873c8e5a70652f278d469128cb52db70 changed the way that >> sysfs attributes are handled. With lockdep checking enabled, a firmware >> loading request from b43 generates the following BUG: >> >> BUG: key ffff8800b85f4870 not in .data! >> ------------[ cut here ]------------ >> WARNING: at kernel/lockdep.c:2706 lockdep_init_map+0x236/0x5d0() > > I don't think we can fix these problems this way. > > Lookie here: > > [torvalds@i5 linux]$ git grep sysfs_create_bin_file | wc > 68 319 5999 > [torvalds@i5 linux]$ git grep sysfs_bin_attr_init | wc > 8 24 522 > > and you sent in patches to fix _two_ of the remaining 60 cases.
Those are the two that showed up on my machine, and as Jiri says, not all 68 will be needed. I need them to see any lockdep problems on the driver I'm developing. I'll watch for developments.
Larry
|  |