Messages in this thread | | | Date | Sat, 13 Mar 2010 11:49:39 -0800 (PST) | Subject | Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style guide | From | David Miller <> |
| |
From: Steven Harms <sjharms@gmail.com> Date: Sat, 13 Mar 2010 14:39:11 -0500
> -#define tw32_mailbox(reg, val) tp->write32_mbox(tp, reg, val) > -#define tw32_mailbox_f(reg, val) tw32_mailbox_flush(tp, (reg), (val)) > -#define tw32_rx_mbox(reg, val) tp->write32_rx_mbox(tp, reg, val) > -#define tw32_tx_mbox(reg, val) tp->write32_tx_mbox(tp, reg, val) > -#define tr32_mailbox(reg) tp->read32_mbox(tp, reg) > +#define tw32_mailbox(reg, val) (tp->write32_mbox(tp, reg, val))
Please keep this kind of code masterbation to yourself. This is not the style we want for this driver.
| |