lkml.org 
[lkml]   [2010]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style guide
From
From: Steven Harms <sjharms@gmail.com>
Date: Sat, 13 Mar 2010 14:39:11 -0500

> -#define tw32_mailbox(reg, val) tp->write32_mbox(tp, reg, val)
> -#define tw32_mailbox_f(reg, val) tw32_mailbox_flush(tp, (reg), (val))
> -#define tw32_rx_mbox(reg, val) tp->write32_rx_mbox(tp, reg, val)
> -#define tw32_tx_mbox(reg, val) tp->write32_tx_mbox(tp, reg, val)
> -#define tr32_mailbox(reg) tp->read32_mbox(tp, reg)
> +#define tw32_mailbox(reg, val) (tp->write32_mbox(tp, reg, val))

Please keep this kind of code masterbation to yourself.
This is not the style we want for this driver.


\
 
 \ /
  Last update: 2010-03-13 20:51    [W:0.097 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site