Messages in this thread | | | Date | Fri, 12 Mar 2010 11:55:04 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH v2 5/5] perf report: Initial TUI using newt |
| |
On 03/12/2010 11:45 AM, Ingo Molnar wrote: > > - When i hit enter on a symbol to annotate it, but the annotation fails, the TUI > just does nothing currently. Instead it should print something informative > (and eye-catching) into a status line at the top or the bottom of the > screen, possibly printed in red characters or so. Not a separate window as that > needs extra key-hits to get rid of - just a sufficiently visible status > line would be perfect. There can be a few reasons why some functions can be > annotated while others cannot be. >
Alternatively, mark it as unannotatable in the first place (e.g. an annotatable symbol is a hyperlink, an unannotatable one is not). But perhaps that's too computationally expensive.
-- Do not meddle in the internals of kernels, for they are subtle and quick to panic.
| |