lkml.org 
[lkml]   [2010]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[005/145] V4L/DVB: Video : pwc : Fix regression in pwc_set_shutter_speed caused by bad constant => sizeof conversion.
    2.6.32-stable review patch.  If anyone has any objections, please let me know.

    ----------------
    From: Martin Fuzzey <mfuzzey@gmail.com>

    commit 53f68607caba85db9a73846ccd289e4b7fa96295 upstream.

    Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
    which determined message size using sizeof rather than hardcoded constants.

    Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
    message too so the sizeof was bogus in this case.

    All other uses of sizeof checked and are ok.

    Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Martin Fuzzey <mfuzzey@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/media/video/pwc/pwc-ctrl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/video/pwc/pwc-ctrl.c
    +++ b/drivers/media/video/pwc/pwc-ctrl.c
    @@ -753,7 +753,7 @@ int pwc_set_shutter_speed(struct pwc_dev
    buf[0] = 0xff; /* fixed */

    ret = send_control_msg(pdev,
    - SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, sizeof(buf));
    + SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, 1);

    if (!mode && ret >= 0) {
    if (value < 0)



    \
     
     \ /
      Last update: 2010-03-13 02:17    [W:0.022 / U:0.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site