Messages in this thread | | | Date | Fri, 12 Mar 2010 13:07:23 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 3/4] of/gpio: Implement GPIOLIB notifier hooks |
| |
On Fri, 5 Feb 2010 23:32:36 +0300 Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> This patch implements GPIOLIB notifier hooks, and thus makes device-enabled > GPIO chips (i.e. the ones that have gpio_chip->dev specified) automatically > attached to the OpenFirmware subsystem. Which means that now we can handle > I2C and SPI GPIO chips almost* transparently. > > ... > > +static int of_gpiochip_register_simple(struct gpio_chip *chip, > + struct device_node *np)
Why is this called "register_simple" but the unregistration function isn't called "unregister_simple"?
> +{ > + struct of_gpio_chip *of_gc; > + > + if (np->data) { > + WARN_ON(1); > + return -EBUSY; > + } > + > + of_gc = kzalloc(sizeof(*of_gc), GFP_KERNEL); > + if (!of_gc) > + return -ENOMEM; > + > + of_gc->gpio_cells = 2; > + of_gc->xlate = of_gpio_simple_xlate; > + of_gc->chip = chip; > + np->data = of_gc; > + of_node_get(np); > + > + return 0; > +} > +EXPORT_SYMBOL(of_gpiochip_register_simple);
Makes no sense to export a static symbol and to provide no declaration of it in a .h file. I assume the export was unintended.
My plot is somewhat lost. Grant, could you please summarise in easy-for-akpm-to-understand terms what your issues are with this patchset and how you think we should proceed?
Thanks.
| |