lkml.org 
[lkml]   [2010]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] enhance sysfs rfkill interface
    On Fri, Mar 12, 2010 at 07:03:08PM +0100, florian@mickler.org wrote:
    >
    > +static ssize_t rfkill_hard_show(struct device *dev,
    > + struct device_attribute *attr,
    > + char *buf)
    > +{
    > + struct rfkill *rfkill = to_rfkill(dev);
    > + unsigned long flags;
    > + u32 state;
    > +
    > + spin_lock_irqsave(&rfkill->lock, flags);
    > + state = rfkill->state;
    > + spin_unlock_irqrestore(&rfkill->lock, flags);

    Why exactly is this lock needed?

    > +
    > + return sprintf(buf, "%d\n", (state & RFKILL_BLOCK_HW) ? 1 : 0 );
    > +}
    > +
    > +static ssize_t rfkill_soft_show(struct device *dev,
    > + struct device_attribute *attr,
    > + char *buf)
    > +{
    > + struct rfkill *rfkill = to_rfkill(dev);
    > + unsigned long flags;
    > + u32 state;
    > +
    > + spin_lock_irqsave(&rfkill->lock, flags);
    > + state = rfkill->state;
    > + spin_unlock_irqrestore(&rfkill->lock, flags);

    And here as well...

    --
    Dmitry


    \
     
     \ /
      Last update: 2010-03-12 19:25    [W:0.023 / U:120.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site