lkml.org 
[lkml]   [2010]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/11] ST SPEAr: Added clock framework for SPEAr platform and machines
On 3/11/2010 3:58 PM, Russell King - ARM Linux wrote:
> On Wed, Mar 03, 2010 at 10:37:35AM +0530, Viresh KUMAR wrote:
>> +/* array of all spear 3xx clock lookups */
>> +static struct clk_lookup *spear_clk_lookups[] = {
>> + /* root clks */
>> + &osc_32k_cl,
>> + &osc_24m_cl,
>
> This is rather wasteful - rather than defining structures, and then having
> a one-time-used set of pointers to the structures, why not just declare
> the whole lot as an array like most other implementations do?
>

I did it to make it more readable. But, obviously it is wasting some amount
of memory for just nothing. Will change it with an array implementation.

regards,
viresh kumar.


\
 
 \ /
  Last update: 2010-03-12 05:27    [W:0.135 / U:0.872 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site