Messages in this thread | | | Subject | Re: madness, was Re: [PATCH 2/2] Macintosh: fix coding style issues in adb.c This is a patch to the adb.c file that cleans up many warnings found by the checkpatch.pl tool | From | Benjamin Herrenschmidt <> | Date | Fri, 12 Mar 2010 08:45:10 +1100 |
| |
On Wed, 2010-03-10 at 14:48 +1100, fthain@telegraphics.com.au wrote: > On Tue, 9 Mar 2010, Michael Beardsworth wrote: > > > - /* If a probe is in progress or we are sleeping, wait for it to complete */ > > + /* If a probe is in progress or we are sleeping, wait until complete */ > > If you must "fix" what aint broke, please try not to damage it. I'm sorry > if your VT52 is limited to 80 cols, but IMNSHO this sort of effort is > misguided. > > Maybe I could point out again (I do this periodically) that checkpatch.pl > is great but code that fails it is NOT always wrong. > > "Check patch" is a good idea but "check existing code" is a waste of > everyone's time.
Amen !
Cheers, Ben.
| |