lkml.org 
[lkml]   [2010]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] perf_events: remove bogus Intel Core constraint on ITLB_MISS_RETIRED
    From
    On Thu, Mar 11, 2010 at 1:07 PM, Peter Zijlstra <peterz@infradead.org> wrote:
    > On Thu, 2010-03-11 at 12:59 -0800, eranian@google.com wrote:
    >> Contrary to what Vol3b section 30.4.3 leads to believe, there is
    >> no constraint on ITLB_MISS_RETIRED on Intel Core-based CPU, so
    >> remove it.
    >
    > Is that from Intel, and will they clarify the text in the next version
    > of the document?
    >
    Yes.

    >> Signed-off-by: Stephane Eranian <eranian@google.com>
    >> --
    >>  perf_event_intel.c |    1 -
    >>  1 file changed, 1 deletion(-)
    >> diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
    >> index 971dc6e..58e83cd 100644
    >> --- a/arch/x86/kernel/cpu/perf_event_intel.c
    >> +++ b/arch/x86/kernel/cpu/perf_event_intel.c
    >> @@ -43,7 +43,6 @@ static struct event_constraint intel_core2_event_constraints[] =
    >>       INTEL_EVENT_CONSTRAINT(0x18, 0x1), /* IDLE_DURING_DIV */
    >>       INTEL_EVENT_CONSTRAINT(0x19, 0x2), /* DELAYED_BYPASS */
    >>       INTEL_EVENT_CONSTRAINT(0xa1, 0x1), /* RS_UOPS_DISPATCH_CYCLES */
    >> -     INTEL_EVENT_CONSTRAINT(0xc9, 0x1), /* ITLB_MISS_RETIRED (T30-9) */
    >>       INTEL_EVENT_CONSTRAINT(0xcb, 0x1), /* MEM_LOAD_RETIRED */
    >>       EVENT_CONSTRAINT_END
    >>  };
    >
    >
    >
    >



    --
    Stephane Eranian  | EMEA Software Engineering
    Google France | 38 avenue de l'Opéra | 75002 Paris
    Tel : +33 (0) 1 42 68 53 00
    This email may be confidential or privileged. If you received this
    communication by mistake, please
    don't forward it to anyone else, please erase all copies and
    attachments, and please let me know that
    it went to the wrong person. Thanks
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-11 22:11    [W:0.021 / U:47.148 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site