Messages in this thread | | | Subject | Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one | From | Joe Perches <> | Date | Wed, 10 Mar 2010 23:21:40 -0800 |
| |
On Thu, 2010-03-11 at 08:18 +0900, OGAWA Hirofumi wrote: > Andy Shevchenko <andy.shevchenko@gmail.com> writes: > > > if (uni_xlate == 1) { > > - *op = ':'; > > - for (k = 4; k > 0; k--) { > > - nc = ec & 0xF; > > - op[k] = nc > 9 ? nc + ('a' - 10) > > - : nc + '0'; > > - ec >>= 4; > > - } > > - op += 5; > > + *op++ = ':'; > > + *op++ = hex_asc_hi(ec >> 8); > > + *op++ = hex_asc_lo(ec >> 8); > > + *op++ = hex_asc_hi(ec); > > + *op++ = hex_asc_lo(ec); > > len -= 5; > > Why doesn't this use pack_hex_byte()?
or snprintf
| |