[lkml]   [2010]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 3/3] GFS2: Skip check for mandatory locks when unlocking
    From: Sachin Prabhu <>

    gfs2_lock() will skip locks on file which have mode set to 02666. This is a problem in cases where the mode of the file is changed after a process has obtained a lock on the file. Such a lock will be skipped and will result in a BUG in locks_remove_flock().

    gfs2_lock() should skip the check for mandatory locks when unlocking a file.

    Signed-off-by: Sachin Prabhu <>
    Signed-off-by: Steven Whitehouse <>
    fs/gfs2/file.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
    index a6abbae..e6dd2ae 100644
    --- a/fs/gfs2/file.c
    +++ b/fs/gfs2/file.c
    @@ -640,7 +640,7 @@ static int gfs2_lock(struct file *file, int cmd, struct file_lock *fl)

    if (!(fl->fl_flags & FL_POSIX))
    return -ENOLCK;
    - if (__mandatory_lock(&ip->i_inode))
    + if (__mandatory_lock(&ip->i_inode) && fl->fl_type != F_UNLCK)
    return -ENOLCK;

    if (cmd == F_CANCELLK) {

     \ /
      Last update: 2010-03-11 18:37    [W:0.026 / U:1.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site