Messages in this thread | | | Subject | Re: [PATCH] lp3971: Fix BUCK_VOL_CHANGE_SHIFT logic | From | Liam Girdwood <> | Date | Thu, 11 Mar 2010 11:18:14 +0000 |
| |
On Thu, 2010-03-11 at 11:04 +0000, Mark Brown wrote: > On Thu, Mar 11, 2010 at 09:56:34AM +0800, axel lin wrote: > > From 99175ed0f281d54efdaf8eef548077a8f0b4924a Mon Sep 17 00:00:00 2001 > > From: Axel Lin <axel.lin@gmail.com> > > Date: Thu, 11 Mar 2010 09:50:07 +0800 > > Subject: [PATCH] lp3971: Fix BUCK_VOL_CHANGE_SHIFT logic > > > > Given x=0,1,2, current implementation of BUCK_VOL_CHANGE_SHIFT(x) returns 0,4,8. > > The correct return value should be 0,4,6. > > This patch fix the logic. > > > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > > with the same comment about ideally wanting someone who worked on the > driver previously to check stuff.
Marek, Kyungmin, could someone please test/ack this before both are applied.
Thanks
Liam
-- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
| |