lkml.org 
[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/6] early_res: seperate common memmap func from e820.c to fw_memmap.c
    On Wed, Mar 10, 2010 at 01:24:26PM -0800, Yinghai Lu wrote:

    > move it to kernel/fw_memmap.c from arch/x86/kernel/e820.c
    >
    > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    >
    > ---
    > arch/x86/include/asm/e820.h | 130 -----
    > arch/x86/kernel/e820.c | 1142 --------------------------------------------
    > include/linux/bootmem.h | 2
    > include/linux/fw_memmap.h | 114 ++++
    > kernel/Makefile | 2
    > kernel/fw_memmap.c | 1134 +++++++++++++++++++++++++++++++++++++++++++

    Yuck. So you think we should use > 1100 lines of fw_memmap.c code
    instead of the 541 lines of lib/lmb.c? Why exactly would that be
    better?

    Paul.


    \
     
     \ /
      Last update: 2010-03-11 00:49    [W:0.021 / U:91.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site