Messages in this thread | | | Date | Wed, 10 Mar 2010 14:58:41 -0800 | From | Greg KH <> | Subject | Re: [patch] numa: fix BUILD_BUG_ON for node_read_distance |
| |
On Wed, Mar 10, 2010 at 02:50:21PM -0800, David Rientjes wrote: > node_read_distance() has a BUILD_BUG_ON() to prevent buffer overruns when > the number of nodes printed will exceed the buffer length. > > Each node only needs four chars: three for distance (maximum distance is > 255) and one for a seperating space or a trailing newline.
Is this causing a problem as-is today that we need to resolve for 2.6.34? Or is this 2.6.35 material?
Who chose this original number, and why is it off by 1/2?
thanks,
greg k-h
| |