lkml.org 
[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH RFC] fix problems with NETIF_F_HIGHDMA in networking drivers v2
    Date
     > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
    > index df3eb8c..53be462 100644
    > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
    > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
    > @@ -1058,7 +1058,7 @@ static void ipoib_setup(struct net_device *dev)
    > dev->type = ARPHRD_INFINIBAND;
    > dev->tx_queue_len = ipoib_sendq_size * 2;
    > dev->features = (NETIF_F_VLAN_CHALLENGED |
    > - NETIF_F_HIGHDMA);
    > + NETIF_F_DMA_HIGH);
    > dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
    >
    > memcpy(dev->broadcast, ipv4_bcast_addr, INFINIBAND_ALEN);

    Been meaning to mention this for a bit, but ipoib is capable of handling
    any DMA address, so if I understand your patch correctly, this can be
    NETIF_F_DMA_64BIT instead of just DMA_HIGH.
    --
    Roland Dreier <rolandd@cisco.com>
    For corporate legal information go to:
    http://www.cisco.com/web/about/doing_business/legal/cri/index.html


    \
     
     \ /
      Last update: 2010-03-10 21:19    [W:0.028 / U:0.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site