Messages in this thread | | | Subject | Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip. | From | (Eric W. Biederman) | Date | Wed, 10 Mar 2010 09:18:38 -0800 |
| |
Ian Campbell <Ian.Campbell@citrix.com> writes:
> On Wed, 2010-03-10 at 10:55 +0000, ijc@hellion.org.uk wrote: >> >> arch_init_chip_data cannot be moved into struct irq_chip at this time >> because irq_desc->chip is not known at the time the irq_desc is >> setup. For now rename arch_init_chip_data to arch_init_irq_desc (for >> PowerPC, the only other user, whose usage better matches the new name) >> and on x86 convert arch_init_chip_data to ioapic_init_chip_data and >> call this whenever the IO APIC code allocates a new IRQ. > > One idea I had to improve this was to add a struct irq_chip * as a > parameter to irq_to_desc_alloc_node. The new parameter potentially could > be NULL for current behaviour. Does that sound like a reasonable > approach?
I don't follow why we have the restriction that irq_to_desc_alloc_node must call arch_init_chip_data. Assuming that requirement to call arch_init_chip_data is valid, passing something into init_one_irq_desc seems appropriate.
Eric
| |