Messages in this thread | | | Date | Wed, 10 Mar 2010 15:44:27 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 02/18] KVM: MMU: Make tdp_enabled a mmu-context parameter |
| |
On Mon, Mar 08, 2010 at 11:17:41AM +0200, Avi Kivity wrote: > On 03/03/2010 09:12 PM, Joerg Roedel wrote: > >This patch changes the tdp_enabled flag from its global > >meaning to the mmu-context. This is necessary for Nested SVM > >with emulation of Nested Paging where we need an extra MMU > >context to shadow the Nested Nested Page Table. > > > > > >diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > >index ec891a2..e7bef19 100644 > >--- a/arch/x86/include/asm/kvm_host.h > >+++ b/arch/x86/include/asm/kvm_host.h > >@@ -254,6 +254,7 @@ struct kvm_mmu { > > int root_level; > > int shadow_root_level; > > union kvm_mmu_page_role base_role; > >+ bool tdp_enabled; > > > > This needs a different name, since the old one is still around. > Perhaps we could call it parent_mmu and make it a kvm_mmu pointer.
Hmm, how about renaming the global tdp_enabled variable to tdp_usable? The global variable indicates if tdp is _usable_ and we can _enable_ it for a mmu context.
Joerg
| |