Messages in this thread Patch in this message | | | Date | Wed, 10 Mar 2010 13:20:54 GMT | From | tip-bot for Peter Zijlstra <> | Subject | [tip:perf/pebs] perf, x86: Fix silly bug in data store buffer allocation |
| |
Commit-ID: 3adaebd69557615c1bf0365ce5e32d93ac7d82af Gitweb: http://git.kernel.org/tip/3adaebd69557615c1bf0365ce5e32d93ac7d82af Author: Peter Zijlstra <a.p.zijlstra@chello.nl> AuthorDate: Fri, 5 Mar 2010 12:09:29 +0100 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Wed, 10 Mar 2010 13:23:34 +0100
perf, x86: Fix silly bug in data store buffer allocation
Fix up the ds allocation error path, where we could free @buffer before we used it.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Arnaldo Carvalho de Melo <acme@infradead.org> Cc: paulus@samba.org Cc: eranian@google.com Cc: robert.richter@amd.com Cc: fweisbec@gmail.com LKML-Reference: <20100305154128.813452402@chello.nl> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- arch/x86/kernel/cpu/perf_event_intel_ds.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_ds.c b/arch/x86/kernel/cpu/perf_event_intel_ds.c index 72453ac..a67fff1 100644 --- a/arch/x86/kernel/cpu/perf_event_intel_ds.c +++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c @@ -127,10 +127,8 @@ static int reserve_ds_buffers(void) err = -ENOMEM; ds = kzalloc(sizeof(*ds), GFP_KERNEL); - if (unlikely(!ds)) { - kfree(buffer); + if (unlikely(!ds)) break; - } per_cpu(cpu_hw_events, cpu).ds = ds; if (x86_pmu.bts) {
| |