Messages in this thread | | | Date | Wed, 10 Mar 2010 04:06:14 -0800 | Subject | Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip. | From | Yinghai Lu <> |
| |
On Wed, Mar 10, 2010 at 2:55 AM, <ijc@hellion.org.uk> wrote: > From: Ian Campbell <ian.campbell@citrix.com> > > Move arch_init_copy_chip_data and arch_free_chip_data into function > pointers in struct irq_chip since they operate on irq_desc->chip_data. > > arch_init_chip_data cannot be moved into struct irq_chip at this time > because irq_desc->chip is not known at the time the irq_desc is > setup. For now rename arch_init_chip_data to arch_init_irq_desc (for > PowerPC, the only other user, whose usage better matches the new name) > and on x86 convert arch_init_chip_data to ioapic_init_chip_data and > call this whenever the IO APIC code allocates a new IRQ. > > I've retained the chip_data behaviour for uv_irq although it isn't > clear to me if these interrupt types support migration or how closely > related to the APIC modes they really are. If it weren't for this the > ioapic_{init,copy,free}_chip_data functions could be static to > io_apic.c. > > I've tested by booting on a 64 bit system, but it's not clear to me > what actions I need to take to actually exercise some of these code > paths. >
can you just add another pointer field in irq_desc?
some kind of *irq_info etc.
YH
| |