[lkml]   [2010]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [tip:x86/irq] x86: apic: Fix mismerge, add arch_probe_nr_irqs() again
    On 03/01/2010 01:44 PM, Ian Campbell wrote:
    >> - Xen has an array irq_info[NR_IRQS] one of the last static arrays
    >> sized at NR_IRQs in the entire kernel.
    > Hopefully the same info as is in that array could (and indeed should) be
    > instead stored in irq_desc->chip_data. Would you object to
    > arch_init_copy_chip_data and arch_free_chip_data becoming function
    > pointers within the struct irq_chip?

    Yes, I was just about to suggest something like this. We just need a
    mechanism of storing some per-irq info, and attaching it to the existing
    desc structure is much cleaner than maintaining some parallel structure.

    You're right about the chip_data lifetime functions; it seems very odd
    that most of irq_chip is nicely factored out into a set of ops, but the
    per-chip data management is per-architecture.

    With that in place, we could eliminate any dependency on irq numbers.


     \ /
      Last update: 2010-03-01 23:03    [W:0.018 / U:387.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site