lkml.org 
[lkml]   [2010]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip:x86/atomic] lib: Fix atomic64_add_unless test
Commit-ID:  9efbcd590243045111670c171a951923b877b57d
Gitweb: http://git.kernel.org/tip/9efbcd590243045111670c171a951923b877b57d
Author: Luca Barbieri <luca@luca-barbieri.com>
AuthorDate: Mon, 1 Mar 2010 19:55:45 +0100
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Mon, 1 Mar 2010 11:38:46 -0800

lib: Fix atomic64_add_unless test

atomic64_add_unless must return 1 if it perfomed the add and 0 otherwise.
The test assumed the opposite convention.

Reported-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
LKML-Reference: <1267469749-11878-2-git-send-email-luca@luca-barbieri.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
lib/atomic64_test.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c
index 58efdab..ee8e6de 100644
--- a/lib/atomic64_test.c
+++ b/lib/atomic64_test.c
@@ -104,11 +104,11 @@ static __init int test_atomic64(void)
BUG_ON(v.counter != r);

INIT(v0);
- BUG_ON(!atomic64_add_unless(&v, one, v0));
+ BUG_ON(atomic64_add_unless(&v, one, v0));
BUG_ON(v.counter != r);

INIT(v0);
- BUG_ON(atomic64_add_unless(&v, one, v1));
+ BUG_ON(!atomic64_add_unless(&v, one, v1));
r += one;
BUG_ON(v.counter != r);


\
 
 \ /
  Last update: 2010-03-01 21:01    [W:0.070 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site