lkml.org 
[lkml]   [2010]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 4/5] lib: fix atomic64_inc_not_zero test
Date
atomic64_inc_not_zero must return 1 if it perfomed the add and 0 otherwise.
The test assumed the opposite convention.

Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
---
lib/atomic64_test.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c
index ee8e6de..f7bb706 100644
--- a/lib/atomic64_test.c
+++ b/lib/atomic64_test.c
@@ -130,16 +130,16 @@ static __init int test_atomic64(void)
#endif

INIT(onestwos);
- BUG_ON(atomic64_inc_not_zero(&v));
+ BUG_ON(!atomic64_inc_not_zero(&v));
r += one;
BUG_ON(v.counter != r);

INIT(0);
- BUG_ON(!atomic64_inc_not_zero(&v));
+ BUG_ON(atomic64_inc_not_zero(&v));
BUG_ON(v.counter != r);

INIT(-one);
- BUG_ON(atomic64_inc_not_zero(&v));
+ BUG_ON(!atomic64_inc_not_zero(&v));
r += one;
BUG_ON(v.counter != r);

--
1.6.6.1.476.g01ddb


\
 
 \ /
  Last update: 2010-03-01 19:59    [W:0.145 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site