lkml.org 
[lkml]   [2010]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: Add OMAP high-speed UART driver.
> +		 213 = /dev/ttyO0		OMAP serial port 0
> + 214 = /dev/ttyO1 OMAP serial port 1
> + 215 = /dev/ttyO2 OMAP serial port 2
> + 216 = /dev/ttyO3 OMAP serial port 3

I think it might be best to allocate a dynamic tty major nowdays

Other problem is that I don't see where you hold the port lock over all
uses of port->tty. That is an assumption of the serial layer and done in
the original 8250 driver correctly.

Rest looks good and I agree that OMAP is different enough from 8250 that
it makes sense not to further clutter the 8250 driver.



\
 
 \ /
  Last update: 2010-03-01 19:11    [W:0.059 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site