Messages in this thread | | | Date | Mon, 1 Mar 2010 18:13:01 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] serial: Add OMAP high-speed UART driver. |
| |
> + 213 = /dev/ttyO0 OMAP serial port 0 > + 214 = /dev/ttyO1 OMAP serial port 1 > + 215 = /dev/ttyO2 OMAP serial port 2 > + 216 = /dev/ttyO3 OMAP serial port 3
I think it might be best to allocate a dynamic tty major nowdays
Other problem is that I don't see where you hold the port lock over all uses of port->tty. That is an assumption of the serial layer and done in the original 8250 driver correctly.
Rest looks good and I agree that OMAP is different enough from 8250 that it makes sense not to further clutter the 8250 driver.
| |