lkml.org 
[lkml]   [2010]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] vhost-net: switch to smp barriers
    Date
    On Sun, 7 Feb 2010 07:37:49 pm Michael S. Tsirkin wrote:
    > On Mon, Feb 01, 2010 at 07:21:02PM +0200, Michael S. Tsirkin wrote:
    > > vhost-net only uses memory barriers to control SMP effects
    > > (communication with userspace potentially running on a different CPU),
    > > so it should use SMP barriers and not mandatory barriers for memory
    > > access ordering, as suggested by Documentation/memory-barriers.txt
    > >
    > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    >
    >
    > Rusty, any feedback on this one?
    > Thanks!

    Yep. barrier() is correct on UP to guard against preemption.

    Acked-by: Rusty Russell <rusty@rustcorp.com.au>

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2010-02-08 09:23    [W:0.018 / U:0.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site