Messages in this thread |  | | | Date | Sun, 7 Feb 2010 14:46:56 +0800 | | From | Américo Wang <> | | Subject | Re: [2.6.33-rc5] tty: possible irq lock inversion dependency in tty_fasync |
| |
On Sat, Feb 06, 2010 at 10:31:30PM -0800, Linus Torvalds wrote: > > >On Sun, 7 Feb 2010, Tetsuo Handa wrote: >> >> Below problem (which was introduced between 2.6.33-rc4 and 2.6.33-rc5) is >> not yet fixed as of 2.6.33-rc7. >> "git bisect start v2.6.33-rc5 v2.6.33-rc4" reported that >> 703625118069f9f8960d356676662d3db5a9d116 tty: fix race in tty_fasync >> is first bad commit. > >Yeah. I think we need to just revert that commit. > >Or maybe we could just do the following, rather than revert it outright: >just get a ref to the 'struct pid' while holding the spinlock, and then >releasing it after doing the __f_setown() call.
We already fixed this, a better fix:
http://lkml.org/lkml/2010/1/26/338
I sent a same fix with Greg's.
Thanks.
|  |