Messages in this thread | | | Date | Sun, 07 Feb 2010 11:56:14 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH] vhost-net: switch to smp barriers |
| |
On 02/07/2010 11:44 AM, Michael S. Tsirkin wrote: > On Sun, Feb 07, 2010 at 11:42:29AM +0200, Avi Kivity wrote: > >> On 02/01/2010 07:21 PM, Michael S. Tsirkin wrote: >> >>> vhost-net only uses memory barriers to control SMP effects >>> (communication with userspace potentially running on a different CPU), >>> so it should use SMP barriers and not mandatory barriers for memory >>> access ordering, as suggested by Documentation/memory-barriers.txt >>> >>> >>> >> A UP guest running on an SMP host still needs those barriers. >> > Correct. And since vhost net is running host-side, smp_XX > barriers will do exactly the right thing, right? >
Right, of course. Mixed up virtio and vhost.
-- error compiling committee.c: too many arguments to function
| |