lkml.org 
[lkml]   [2010]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6.33-rc5] tty: possible irq lock inversion dependency in tty_fasync
On Sat, Feb 06, 2010 at 10:46:01PM -0800, Linus Torvalds wrote:
>
>
> On Sat, 6 Feb 2010, Linus Torvalds wrote:
> >
> > Yeah. I think we need to just revert that commit.
> >
> > Or maybe we could just do the following, rather than revert it outright:
> > just get a ref to the 'struct pid' while holding the spinlock, and then
> > releasing it after doing the __f_setown() call.
>
> Btw, if we do this, then we should probably revert commit
> b04da8bfdfbbd79544cab2fadfdc12e87eb01600 at the same time.
>
> Resulting patch would then look like the appended.

The patch looks correct to me, thanks for fixing this.

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

Can you commit it to your tree, or do you need/want me to submit it?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-02-07 08:29    [W:2.085 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site