Messages in this thread | | | Date | Fri, 05 Feb 2010 19:03:20 +1100 | From | Nigel Cunningham <> | Subject | Re: [linux-pm] [PATCH 1/2] PM / Runtime: Add sysfs switch for disabling device run-time PM (rev. 2) |
| |
Hi Pavel et al.
Pavel Machek wrote: > Hi! > >> /* >> + * control - Report/change current runtime PM setting of the device >> + * >> + * Runtime power management of a device can be blocked with the help of >> + * this attribute. All devices have one of the following two values for >> + * the power/control file: >> + * >> + * + "auto\n" to allow the device to be power managed at run time; >> + * + "on\n" to prevent the device from being power managed at run time; > > I find interface with mandatory \n quite 'interesting'.
Agreed.
> Plus english is strange here. All devices have ... "auto" to allow...? > Strange formulation. List the values first, then add "write ... to allow"?
It seems okay to me because of the preceding sentence ending in a colon.
Regards,
Nigel
| |