lkml.org 
[lkml]   [2010]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [linux-pm] [PATCH 1/2] PM / Runtime: Add sysfs switch for disabling device run-time PM (rev. 2)
    Hi Pavel et al.

    Pavel Machek wrote:
    > Hi!
    >
    >> /*
    >> + * control - Report/change current runtime PM setting of the device
    >> + *
    >> + * Runtime power management of a device can be blocked with the help of
    >> + * this attribute. All devices have one of the following two values for
    >> + * the power/control file:
    >> + *
    >> + * + "auto\n" to allow the device to be power managed at run time;
    >> + * + "on\n" to prevent the device from being power managed at run time;
    >
    > I find interface with mandatory \n quite 'interesting'.

    Agreed.

    > Plus english is strange here. All devices have ... "auto" to allow...?
    > Strange formulation. List the values first, then add "write ... to allow"?

    It seems okay to me because of the preceding sentence ending in a colon.

    Regards,

    Nigel



    \
     
     \ /
      Last update: 2010-02-05 09:03    [W:0.022 / U:0.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site